Closing dialogs with ESC key or background is not prevented #50

New Issue

2025-10-30T11:47:17+01:00

vollstock commented

2025-10-30 11:47:17 +01:00

In the invoiceDialog#292 closing with background clicking and escape key calls cancelChanges, which sets a callback.

With the new alert.show() function the event isn't even passed to the callback so this can never work:

event.preventDefault()
event.returnValue = true

However even befor, the event wasn't prevented in all circumstances.

Needs fixing and testing.

In the [`invoiceDialog#292`](http://code.tooloop.de/Tooloop/Caramel-CRM/src/commit/cacc3d59430b5eba178f927cd7801128328b217e/resources/js/components/documents/InvoiceDialog.vue#L292) closing with background clicking and escape key calls `cancelChanges`, which sets a callback. With the new `alert.show()` function the event isn't even passed to the callback so this can never work: ``` event.preventDefault() event.returnValue = true ``` However even befor, the event wasn't prevented in all circumstances. Needs fixing and testing.

vollstock added the Bug label 2025-10-30 11:47:17 +01:00

vollstock added this to the 1.0 project 2025-10-30 11:47:17 +01:00

vollstock added this to the 1.0 milestone 2025-12-04 10:26:14 +01:00

This repo is archived. You cannot comment on issues.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Tooloop/Caramel-CRM-Backup#50