From 25034ee2f3c7b4a7010b1432b5d08248de5f50b0 Mon Sep 17 00:00:00 2001 From: Daniel Stock Date: Fri, 5 Dec 2025 09:53:28 +0100 Subject: [PATCH] Comments on #167 --- app/Listeners/ScheduleListener.php | 3 +++ app/Providers/EventServiceProvider.php | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/Listeners/ScheduleListener.php b/app/Listeners/ScheduleListener.php index 328eaff..9759219 100644 --- a/app/Listeners/ScheduleListener.php +++ b/app/Listeners/ScheduleListener.php @@ -18,6 +18,9 @@ class ScheduleListener */ public function handle($event) { + // TODO: this check is also done, when registering the listener EventServiceProvider.php + // it can probably be removed here safely which would spare a database call on each request + // only run when internal scheduling is enabled (defensive) $method = Setting::where('key', 'app.schedule_method')->value('value') ?? 'internal'; if ($method !== 'internal') { diff --git a/app/Providers/EventServiceProvider.php b/app/Providers/EventServiceProvider.php index f223e48..0df9e53 100644 --- a/app/Providers/EventServiceProvider.php +++ b/app/Providers/EventServiceProvider.php @@ -29,7 +29,7 @@ public function boot(): void } } - // TODO: read where to put these + // TODO: read where to put these or ask in the forums // it seems to work here, but where is the apropriate place? // Kernel::schedule did not work Schedule::command('caldav:sync')